Make Preparer extend Serializable #422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
|
merge when green! |
avibryant
added a commit
that referenced
this pull request
Feb 27, 2015
Make Preparer extend Serializable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aggregators created through the Preparer interface retain references to the original Map/FlatMap Preparer instance. For Summingbird Storm jobs, this causes issues since the aggregators need to be Java serializable.
While we could try to construct the instances such that we don't retain any unnecessary references, it seems simpler to just make Preparer extend Serializable to avoid any issues in the future.
cc @avibryant