Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make MutableBackedMap Serializable. #424

Merged
merged 1 commit into from
Mar 9, 2015
Merged

Make MutableBackedMap Serializable. #424

merged 1 commit into from
Mar 9, 2015

Conversation

tixxit
Copy link
Contributor

@tixxit tixxit commented Mar 5, 2015

Makes MutableBackedMap Serializable so that the result of Semigroup.sumOption can be serialized.

@tixxit
Copy link
Contributor Author

tixxit commented Mar 8, 2015

The failure looks to be unrelated/spurious.

@tixxit tixxit closed this Mar 8, 2015
@tixxit tixxit reopened this Mar 8, 2015
@johnynek
Copy link
Collaborator

johnynek commented Mar 9, 2015

sorry for the noisey test. Our approximate laws are pretty poorly configured. Restarted the build. Thanks for the fix (not sure why it never came up before. Are you using Kryo here? Is this with Spark?).

@tixxit
Copy link
Contributor Author

tixxit commented Mar 9, 2015

Yes, found this using Spark.

johnynek added a commit that referenced this pull request Mar 9, 2015
@johnynek
Merge pull request #424 from tixxit/bug/mutablebackedmap-is-serializable
f358481 
Make MutableBackedMap Serializable.
@johnynek johnynek merged commit f358481 into twitter:develop Mar 9, 2015
@tixxit tixxit mentioned this pull request Mar 11, 2015
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tixxit @johnynek