Replace scrooge-runtime with scrooge-serializer and fix errors. #141
Conversation
Replace scrooge-runtime with scrooge-serializer and fix errors.
| @@ -184,7 +184,7 @@ object BijectionBuild extends Build { | |||
| osgiExportAll("com.twitter.bijection.scrooge"), | |||
| libraryDependencies ++= Seq( | |||
| "org.apache.thrift" % "libthrift" % "0.6.1" exclude("junit", "junit"), | |||
| "com.twitter" % "scrooge-runtime" % "3.0.4" | |||
| "com.twitter" % "scrooge-serializer_2.9.2" % "3.6.0" | |||
There was a problem hiding this comment.
why not use sbt's %% operator?
"com.twitter" % "scrooge-serializer" %% "3.6.0"
There was a problem hiding this comment.
Good point, bug. Fixing.
There was a problem hiding this comment.
Jeff Smick mailto:notifications@github.com
September 13, 2013 2:26 PMIn project/Build.scala:
@@ -184,7 +184,7 @@ object BijectionBuild extends Build {
osgiExportAll("com.twitter.bijection.scrooge"),
libraryDependencies ++= Seq(
"org.apache.thrift" % "libthrift" % "0.6.1" exclude("junit", "junit"),
- "com.twitter" % "scrooge-runtime" % "3.0.4"
- "com.twitter" % "scrooge-serializer_2.9.2" % "3.6.0"
why not use sbt's %% operator?
"com.twitter" % "scrooge-serializer" %% "3.6.0"—
Reply to this email directly or view it on GitHub
https://github.com/twitter/bijection/pull/141/files#r6359420.Argyris Zymnis mailto:notifications@github.com
August 30, 2013 4:41 PM
You can merge this Pull Request by runninggit pull https://github.com/azymnis/bijection argyris/fix_scrooge_breaks
Or view, comment on, or merge it at:
Commit Summary
Replace scrooge-runtime with scrooge-serializer and fix errors.
File ChangesM
bijection-scrooge/src/test/scala/com/twitter/bijection/scrooge/TestStruct.scala
https://github.com/twitter/bijection/pull/141/files#diff-0 (29)M project/Build.scala
https://github.com/twitter/bijection/pull/141/files#diff-1 (4)Patch Links:
Sam Ritchie, Twitter Inc
703.662.1337
@sritchie
No description provided.