Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update jackson-mapper-asl to version 1.9.2 #155

Merged
merged 1 commit into from
Aug 29, 2014
Merged

Conversation

wentsul
Copy link
Contributor

@wentsul wentsul commented Dec 17, 2013

  • Updates jackson-mapper-asl version 1.9.2
  • Replace all deprecated methods in JsonInjection.scala

@comp615
Copy link

comp615 commented Dec 17, 2013

Awesome!

@johnynek
Copy link
Collaborator

Can you describe the win here?

We are a bit conservative about dependencies as we often get burned with diamonds in the large builds of twitter internal projects.

I think you should be okay, as long as jackson uses semver, to use a later version with bijection-json (until 2.x.y). Are you seeing a problem that this fixes?

@wentsul
Copy link
Contributor Author

wentsul commented Dec 23, 2013

I ended up getting around the issue I was running into by passing the -Dmapreduce.task.classpath.user.precedence=true option into my hadoop job. I originally thought there was an issue between the internal twitter version (1.9.2) and this version but turns out it was a conflict between the jackson 1.8+ and the version of jackson running on some of the older hadoop clients (1.5.2). mapJson#invert depends on [JsonNode#getFields](http://jackson.codehaus.org/1.9.2/javadoc/org/codehaus/jackson/JsonNode.html#getFields(\)) which was introduced in version 1.8. Flipping the classpath works for me but isn't an ideal solution.

Since the fix was not related to upgrading to 1.9.2 feel free to close this pull request.

Thanks,
Michael

johnynek added a commit that referenced this pull request Aug 29, 2014
Update jackson-mapper-asl to version 1.9.2
@johnynek johnynek merged commit 69f17b2 into develop Aug 29, 2014
@johnynek johnynek deleted the jackson-mapper-update branch August 29, 2014 20:18
@johnynek
Copy link
Collaborator

Sorry this sat so long. We are conservative with dependency upgrades.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants