Pin bijection-guava to jsr305 1.3.9. #164
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bijection-guava module works around guava only requiring jsr305 in
provided scope yet scalac needing all java annotations at compile time
by adding an explicit dep on jsr305. It was using a valid ivy
revision string with a trailing +, ie: '1.3.+' - and this works fine
for sbt / ivy; however make-pom does not attempt to map ivy version
numbers to valid pom version numbers and a trailing + is treated as a
literal and not a ranged version by maven / pom consumers [1]. This
work-around just pins jsr305 to 1.3.9 which is what guava 14 asks for
(in provided scope) in its own pom. Another valid approach is to use
'[1.3,)' as the version which is valid in ivy.xml, sbt and pom.xml,
but fwict the original use of '1.3.+' was just copypasta from this bug
report: http://code.google.com/p/guava-libraries/issues/detail?id=1095
[1] https://github.com/sbt/sbt/blob/b7c50d42698f8309c76ed5fd0efbb3ef61ee601e/ivy/src/main/scala/sbt/MakePom.scala