Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repro ser/de failures and add tests #241

Merged
merged 2 commits into from
Feb 3, 2016
Merged

Repro ser/de failures and add tests #241

merged 2 commits into from
Feb 3, 2016

Conversation

johnynek
Copy link
Collaborator

@johnynek johnynek commented Feb 3, 2016

not fixed yet:

[info] - round trip List[Int] <=> Vector[String @@ Rep[Int]] *** FAILED ***
[info]   NotSerializableException was thrown during property evaluation.
[info]     Message: scala.collection.generic.GenTraversableFactory$ReusableCBF
[info]     Occurred when passed generated values (
[info]   
[info]     )

[info] - round trip Vector[Double] <=> Vector[String @@ Rep[Double]] *** FAILED ***
[info]   NotSerializableException was thrown during property evaluation.
[info]     Message: scala.collection.IndexedSeq$$anon$1
[info]     Occurred when passed generated values (
[info]   
[info]     )
[info] - round trip Set[Double] <=> Set[String @@ Rep[Double]] *** FAILED ***
[info]   NotSerializableException was thrown during property evaluation.
[info]     Message: scala.collection.generic.GenSetFactory$$anon$1
[info]     Occurred when passed generated values (
[info]   
[info]     )
[info] - round trip Seq[Double] <=> Seq[String @@ Rep[Double]] *** FAILED ***
[info]   NotSerializableException was thrown during property evaluation.
[info]     Message: scala.LowPriorityImplicits$$anon$1
[info]     Occurred when passed generated values (
[info]   
[info]     )
[info] - round trip Map[Long,Double] <=> Map[String @@ Rep[Long], String @@ Rep[Double]] *** FAILED ***
[info]   NotSerializableException was thrown during property evaluation.
[info]     Message: scala.collection.generic.GenMapFactory$MapCanBuildFrom
[info]     Occurred when passed generated values (
[info]   
[info]     )
[info] - round trips string -> Array[String] *** FAILED ***
[info]   NotSerializableException was thrown during property evaluation.
[info]     Message: com.twitter.bijection.AtomicSharedState
[info]     Occurred when passed generated values (
[info]   
[info]     )

@johnynek
Copy link
Collaborator Author

johnynek commented Feb 3, 2016

@bkirwi any ideas on how to make the collection ones serializable?

@ianoc can you see if twitter tests pass with just String to Array[Bytes] being serializable?

@johnynek johnynek changed the title Repro ser/do failures and add tests Repro ser/de failures and add tests Feb 3, 2016
@johnynek
Copy link
Collaborator Author

johnynek commented Feb 3, 2016

I tried making the implicits call by name, but thats not allowed.

Maybe these are just not serialized or if they are it happens behind a chill Externalizer.

ianoc added a commit that referenced this pull request Feb 3, 2016
Repro ser/de failures and add tests
@ianoc ianoc merged commit 53c4738 into develop Feb 3, 2016
@ianoc ianoc deleted the oscar/fixser branch February 3, 2016 04:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants