Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ComposePreviewPublic to not look into non-public methods #85

Merged
merged 1 commit into from
Sep 27, 2022

Conversation

mrmans0n
Copy link
Contributor

ComposePreviewPublic was looking into private/internal methods and could have false positives if they used PreviewParameters. This patch changes that behavior and adds a test to prevent regressions.

`ComposePreviewPublic` was looking into private/internal methods and could have false positives if they used `PreviewParameter`s. This patch changes that behavior and adds a test to prevent regressions.
@mrmans0n mrmans0n merged commit e95198f into main Sep 27, 2022
@mrmans0n mrmans0n deleted the nacho/fix-public-previews branch September 27, 2022 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants