Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify Cookie API with a CookieBuilder #93

Closed
capotej opened this issue Jan 9, 2014 · 2 comments
Closed

Simplify Cookie API with a CookieBuilder #93

capotej opened this issue Jan 9, 2014 · 2 comments
Milestone
1.6.x

Comments

@capotej
Copy link
Contributor

capotej commented Jan 9, 2014

It's a bit hard to create finagle cookies right now:

new Cookie(new DefaultCookie("foo", "bar")

Let's create a CookieBuilder to make it easier
@zuercher
Copy link

zuercher commented Jan 9, 2014

Deleting a cookie is an even bigger pain. Would be cool if the cookie builder could help help with that, too.

@scosenza
Copy link
Contributor

https://github.com/twitter/finatra/blob/master/http/src/test/scala/com/twitter/finatra/http/response/ResponseBuilderTest.scala#L52

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
1.6.x
Development

No branches or pull requests
3 participants
@capotej @zuercher @scosenza