-
Notifications
You must be signed in to change notification settings - Fork 405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependencies, drop scala 2.9 and add scala 2.11 support #185
Conversation
Thanks for doing this, @c089! One note: I haven't looked closely enough to figure out whether this is likely to cause problems later on, and it's obviously not a solution, but it might allow you to do some local experimentation while we work toward a real fix. |
Ah yes, forgot to mention, there is some issue with the coverage plugins not being found, too (that's why CI failed). WIll investigate that. |
You're right, it seems their 2.10 extensions work fine with 2.11. I did a PR to explicitly build a 2.11 version anyway: spullara/mustache.java#118 |
this fixes using the new coverage plugin and should fix the travis build
(fixes a compile-time warning)
That seems to work pretty good now. There are some compile-time warnings I'm not sure how to handle:
|
@travisbrown do you think we need to keep the two scala versions in |
@c089 It can be nice to tell at a glance whether the build is failing only for a particular Scala version, so I'd vote to leave them. |
Oh yeah that makes sense compared with sbt's verbose logging :) |
Updated the description with a task list, let me know if there's any other things to do. as an long-term idea, wouldn't it make sense to decouple the mustache-depdendent part? sucks to be blocked from release by a templating engine (even though it's my preferred one ;)) |
:/ would like to see this happen, but looks like mustache.java work isn't done yet |
Prodded Sam and mustache.java has scala-extensions for scala 2.11 |
Nice, thanks :) I'm having trouble building this PR right now. Will investigate later today and build against the new mustache release. |
FYI, we're still blocked by mustache.java. The release is tagged, but not published :/ |
(I still get some refelction error when building with mvn though :/)
We're actually not going to support scala 2.11 in the 1.x.x series, Finatra 2.x.x is dropping soon and supports both scala 2.11 and 2.10 (but not 2.9). Thanks everyone. |
Sounds like a good reason to bump a major version :) Have you already started work on this on another branch / is this PR still needed? |
Hi Christoph, |
Can we have a sneak peek of the new 2.x branch ? @capotej |
+1 |
2 similar comments
+1 |
+1 |
Update dependencies, build scripts and documentation for moving to scala 2.11. 2.10 is still supported, while 2.9 has to be dropped.
TwitterObjectHandler
here, which has been removed from mustache (TODO: ok like this?)