Fixed parsing issue in the decoder when maxHeaderTableSizeChangeRequired... #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpinner
pushed a commit
that referenced
this pull request
Feb 24, 2015
|
Uncovered a second bug in when updating the header table capacity. Both fixed in 9b2441f. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When "max header table size" is set, the first byte is typically 0x3f (0x20 | 0x1f), assuming the new value needs more than 5 bits. The test in incorrect, and the "max header table size change required" exception gets thrown when it should not. This causes some issues in netty 4.1+ when the server sets the max header table size in settings.