Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update TIP to v2.12.2 #45

Merged
merged 1 commit into from
Jun 4, 2019
Merged

Update TIP to v2.12.2 #45

merged 1 commit into from
Jun 4, 2019

Conversation

NSProgrammer
Copy link
Collaborator

2.12.2

  • Add automatic handling of unnecessary image download errors when the download has finished loading
    • It is not uncommon for a service/CDN to yield an error after the final byte of the response has been loaded by the client
    • The consequence of treating a successful load as a failure is that upon next fetch for that image an unnessecary network request will trigger:
      • For image resumption supported loads, resumes the load beyond the available byte range
      • For full image loads, a redundant download
    • When TIP sees an error on image download but has all the bytes (looking at Content-Length header), TIP now posts TIPProblemImageDownloadedWithUnnecessaryError problem

Also, many misc bug fixes

### 2.12.2

- Add automatic handling of unnecessary image download errors when the download has finished loading
  - It is not uncommon for a service/CDN to yield an error after the final byte of the response has been loaded by the client
  - The consequence of treating a successful load as a failure is that upon next fetch for that image an unnessecary network request will trigger:
    - For image resumption supported loads, resumes the load beyond the available byte range
    - For full image loads, a redundant download
  - When TIP sees an error on image download but has all the bytes (looking at `Content-Length` header), TIP now posts `TIPProblemImageDownloadedWithUnnecessaryError` problem

Also, many misc bug fixes
@NSProgrammer
Copy link
Collaborator Author

merging despite build failures. appears to be travic-ci issue.

@NSProgrammer NSProgrammer merged commit 63deaed into master Jun 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant