Signature failures #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Base64Util.equals(UrlDecoder(request.signature).trim, | ||
| signer.getBytes(request.normalizedRequest, tokenSecret, consumerSecret)) | ||
| } catch { | ||
| case e: Exception => return false |
There was a problem hiding this comment.
log enough at debug level so that we could debug this in production if necessary
|
as discussed with Steven, Joauth doesn't do logging today. We'll add that separately and handle this there. |
kevinoliver
added a commit
that referenced
this pull request
Mar 12, 2013
Handle exceptions in signature failures
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exceptions thrown in Verifier.validateSignature should be treated as bad signatures.