Add comments for memory-related reduce operations. #1006
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
merge when green. |
| @@ -84,6 +84,11 @@ object Grouped { | |||
| } | |||
| } | |||
|
|
|||
| /** | |||
| * All sorting methods defined in this trait are using | |||
| * Hadoop's reducer-side external sorting. i.e. it won't | |||
There was a problem hiding this comment.
aka 'secondary sorting' in Hadoop. Could say 'All sorting methods defined here trigger Hadoop secondary sort on value. i. e. won't materialize all values of each key in memory on the reducer'.
I should add a description to recent 'qna' expanding on answer that Oscar gave about using sortWithTake().
There was a problem hiding this comment.
Sure, this makes the comments further clearer.
|
Good patch btw. I felt the same : there are multiple places where we can add or expand scaladoc. You actually did it :) |
|
👍 |
jcoveney
added a commit
that referenced
this pull request
Aug 8, 2014
Add comments for memory-related reduce operations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #1000.
I found this documentation useful myself. Since when I was choosing sorting approaches, I would like to know which uses a in-memory heap and which uses external sorting.