Ianoc/type descriptor #1147
Merged
Ianoc/type descriptor #1147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| package com.twitter.scalding | ||
|
|
||
| import cascading.tuple.Fields | ||
|
|
There was a problem hiding this comment.
Let's add a comment here:
/**
* This class is used to bind together a Fields instance which may contain a type array via getTypes,
* a TupleConverter and TupleSetter, which are inverses of one another. Note the size of the Fields
* object and the arity values for the converter and setter are all the same. Note in the scalding-macros
* package there are macros to generate this for case classes, which may be very convenient.
*/
|
Merged develop + added comment as noted |
|
Merge when green. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the type descriptor macro and type. Will need a develop merge once the other PR goes in to make it look smaller.