Add UnitOrderedSerialization #1304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gabriella439
added a commit
that referenced
this pull request
Jun 3, 2015
Add UnitOrderedSerialization
|
Mm I didn't think we were merging this ? On Wednesday, June 3, 2015, Gabriel Gonzalez notifications@github.com
|
|
I thought we were merging this for an internal release? Mansur said that he needed this for adding hyperdoop support to Tsar If you're referring to the travis failure, I fixed the failing tests already. They were just missing an import However, I'm okay with reverting this if necessary |
|
I talked with Ian offline about this. I didn't realize that develop was not used for changes being tested in internal releases. I'll revert this change and open up a new pull request to replace the original. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1297
I'm not sure we should merge this yet. I'm concerned this is going to increase serialization costs unless we add tokens for the Boxed class wrappers that we use to do the dispatch to find the correct serializers.
Also, We should not merge this until we are sure we worked out all the bugs and perf issues at Twitter, since this will impact anyone using groupAll.