Ianoc/configure set converter #1400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…igureSetConverter Conflicts: project/Build.scala
|
|
||
| conf.set(ConfigBinaryConverterProvider.ProviderConfKey, ExternalizerSerializer.inj(extern)) | ||
|
|
||
| LzoGenericScheme.setConverter(conv, conf) |
There was a problem hiding this comment.
So we don't want to set the converter here when it's already been set earlier. I'm guessing this is because we want it to be configurable via the new method, before this scheme code is executed?
There was a problem hiding this comment.
Exactly, if something else has gotten there first and wanted to set how the deserialization between the two fixed types is done we don't want to override. I'd view this as the default path per say.
Use case so far is that I can swap out different thrift implementations for testing by setting this param
|
LGTM |
| if ((conf.get(ConfigBinaryConverterProvider.ProviderConfKey) == null) || overrideConf) { | ||
| val extern = Externalizer(conv) | ||
| try { | ||
| ExternalizerSerializer.inj.invert(ExternalizerSerializer.inj(extern)).get |
There was a problem hiding this comment.
we should move this to ExternalizerSerialization.testRoundTrip(i: Any): Try[Unit]
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows using the object to set the configuration of which deserializer is being used.