Extend TextLine with TypedSink #1752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
can we add a test to https://github.com/twitter/scalding/blob/develop/scalding-core/src/test/scala/com/twitter/scalding/TypedPipeTest.scala. We should use |
snoble
force-pushed
the
snoble/TextLine-TypedSink
branch
from
ae8f1f0
to
8d82557
Compare
|
@johnynek test added |
johnynek
reviewed
Oct 31, 2017
| // For some Java interop | ||
| implicit val tset: TupleSetter[String] |
There was a problem hiding this comment.
does this need to be implicit? And can it be private[this] val...
| @@ -523,9 +523,13 @@ object TextLine { | |||
| new TextLine(p, sm, textEncoding) | |||
| } | |||
|
|
|||
| class TextLine(p: String, override val sinkMode: SinkMode, override val textEncoding: String) extends FixedPathSource(p) with TextLineScheme { | |||
| class TextLine(p: String, override val sinkMode: SinkMode, override val textEncoding: String)( | |||
| implicit val tset: TupleSetter[String] | |||
There was a problem hiding this comment.
can we remove this and instead do:
override def setter[U <: String] = TupleSetter.asSubSetter[String, U](TupleSetter.of[String]) taking the implicit in the constructor changes the binary compatibility without a need that I see.
|
I'll figure out why this test is failing tomorrow |
|
Nice work @snoble ! Thanks for fixing this broken window! |
johnynek
pushed a commit
that referenced
this pull request
Dec 19, 2017
* Extend TextLine with TypedSink * Add test for TextLine * Remove need for implicit * Add run so scalding-core tests pass * TextLine requires an offset. Need a separate test name for run and runhadoop
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1751
attn @johnynek