Fix AddExplicitFork #1753
Merged
Fix AddExplicitFork #1753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnynek
commented
Nov 4, 2017
| case Fork(_) | ForceToDisk(_) => None // these are already forking | ||
| case SourcePipe(_) => None // don't need to worry about sources | ||
| case IterablePipe(_) => None // don't need to worry about sources | ||
| case nonFork if on.fanOut(nonFork) > 1 => Some(Fork(nonFork)) |
There was a problem hiding this comment.
this was unsafe. If Fork(nonFork) already exists, then replacing nonFork with Fork(nonFork) creates an infinite loop.
|
sorry i had read through this mostly before. LGTM |
|
I'm still familiarizing with dagon and the new ast/rules, but LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this closes #1747
The problem is that we were sometimes had
(a -> b -> ...)and replacesbwitha -> bwhich makes an infinite loop ata.The solution is just writing the rule more carefully, but it is much more complex.
See the example test we added to dagon:
stripe/dagon#18
cc @fwbrasil @non