Use chill.ClosureCleaner to remove outer$ refs on Functions #273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like there are serialization errors going on here with this change. Need to look more carefully at what is going on. Candidates: maybe ClosureCleaner needs to be Serializable. Maybe there is some breakage with the ClosureCleaner itself. Maybe chill is having problem serializing some resulting data. |
|
Actually, it looks like ClosureCleaner is either a no-op or busted now, so let's hold off here. Watch this issue: Once this is good, we can reconsider. |
|
I am starting to think this closure cleaner thing is only useful for a repl. Closing until we get someone working on that or we prove otherwise. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working around this bug:
https://issues.scala-lang.org/browse/SI-1419