Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix intersection equality error #878

Merged
merged 1 commit into from
May 24, 2014
Merged

Fix intersection equality error #878

merged 1 commit into from
May 24, 2014

Conversation

jcoveney
Copy link
Contributor

closes #877

@jcoveney
Copy link
Contributor Author

Would love to get a test in for this if I have time tomorrow but otherwise this fixes it

@ianoc
Copy link
Collaborator

ianoc commented May 21, 2014

PR/changes look fine, though I'm slow to close this with out any other issues/tests since obviously this was quite broken before... (looks like there have been many issues with this skew join going back)

@jcoveney
Copy link
Contributor Author

I'll try and add a test, should be easy to do

@jcoveney
Copy link
Contributor Author

This is actually something tricky to test for...since if it thinks there is a collision it then renames and then names back, I don't think there was actually a bug. It was just going through an extra renaming step.

@johnynek
Copy link
Collaborator

I agree that this is not a bug, but a performance optimization that was not being triggered due this bug (lack of type safety on ==).

I also agree that the .isEmpty fix here is the right way.

@jcoveney
Copy link
Contributor Author

Click that M button :)

johnynek added a commit that referenced this pull request May 24, 2014
Fix intersection equality error
@johnynek johnynek merged commit 6b63573 into develop May 24, 2014
@johnynek johnynek deleted the jco/877 branch May 24, 2014 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JoinAlgorithms#skewJoinWithSmaller 'intersection == 0'
3 participants