TypedPipe.from(List).distinct fails #935
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -522,7 +522,7 @@ final case class IterablePipe[T](iterable: Iterable[T], | |||
| .getOrElse(EmptyValue()(fd, mode)) | |||
|
|
|||
| override def sumByLocalKeys[K, V](implicit ev: T <:< (K, V), sg: Semigroup[V]) = | |||
| IterablePipe(MapAlgebra.sumByKey(iterable.map(ev(_))), fd, mode) | |||
| IterablePipe(iterable.map(ev(_)).groupBy(_._1).mapValues(_.map(_._2).reduce(sg.plus(_, _))), fd, mode) | |||
There was a problem hiding this comment.
I think mapValues(sg.sumOption(_).get) should work here. The empty case does not come up: each key has at least one value.
johnynek
added a commit
that referenced
this pull request
Jul 3, 2014
TypedPipe.from(List).distinct fails
|
If you want to do the sumOption, that's fine too, but this is green, and since this in-memory lists are probably not huge, it's fine if this does not make it into scalding 0.11.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR to surface an issue, and I will work on the fix.
This was brought up on the mailing list -- TypedPipe.from(List("a","b","c")).distinct doesn't work, but TypedPipe.from(List("a","b","c")).distinctBy(identity) does.
Note: we may want to remove the 2 test cases that pass, since it's just more overhead. On the other hand, they do all share one cluster so the cost isn't TOO high and it does make the issue clear and prevent other regressions.