Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interested in adding support for typescript? #339

Open
alexduf opened this issue Nov 19, 2020 · 3 comments
Open

Interested in adding support for typescript? #339

alexduf opened this issue Nov 19, 2020 · 3 comments

Comments

@alexduf
Copy link

alexduf commented Nov 19, 2020

Hi everyone,

The Guardian has developed a Typescript extension to the scrooge compiler, would you be interested in merging it upstream?

I can see the scrooge compiler already support a number of languages, and I've noticed there was a generic "hook" enabling anyone to add support for any language. For our own needs at the Guardian we took advantage of that hook and implemented a Typescript backend for the scrooge compiler. We're happy to keep the two projects separate, but I wondered if there was any appetite from Twitter or any other users to seeing it pushed upstream.

More info: https://github.com/guardian/scrooge-extras

Let me know your thoughts!

@mosesn
Copy link
Contributor

mosesn commented Nov 21, 2020

@alexduf thanks for reaching out! I'm glad to hear that you were able to add support for Typescript! In the past, we've been cautious about accepting contributions that we don't have the expertise to maintain ourselves, because we're worried that we won't be very good maintainers of them. I think that Typescript falls under that category too.

However, maybe a good approach here would be to add a link in the Scrooge docs to guardian/scrooge-extras so that potential users know where to look?

@alexduf
Copy link
Author

alexduf commented Nov 23, 2020

Thanks for your reply @mosesn!

That makes complete sense to me, I would need to do some cleanup of our documentation and sbt plugin as they are currently very Guardian centric.

Would it be alright if I re-opened this conversation once we're ready to be linked in the scrooge docs?

@mosesn
Copy link
Contributor

mosesn commented Nov 23, 2020

@alexduf yes please!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants