This repository has been archived by the owner on Jan 20, 2022. It is now read-only.
Summingbird changes for Algebird 0.13.0 #715
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piyushnarang
changed the title
Codecov Report
@@ Coverage Diff @@
## develop #715 +/- ##
===========================================
+ Coverage 70.84% 70.96% +0.11%
===========================================
Files 141 141
Lines 3471 3468 -3
Branches 195 195
===========================================
+ Hits 2459 2461 +2
+ Misses 1012 1007 -5
Continue to review full report at Codecov.
|
piyushnarang
changed the title
|
@pankajroark / @johnynek / @ttim - please take a look when you can, thanks. |
johnynek
suggested changes
Feb 16, 2017
| @@ -81,7 +79,7 @@ class HDFSStateLaws extends WordSpec { | |||
| } | |||
| } | |||
|
|
|||
| def leftClosedRightOpenInterval(low: Timestamp, high: Timestamp) = Interval.leftClosedRightOpen[Timestamp](low, high).right.get | |||
| def leftClosedRightOpenInterval(low: Timestamp, high: Timestamp) = Interval.leftClosedRightOpen[Timestamp](low, high) | |||
There was a problem hiding this comment.
can we put a type on the result here? Interval[Timestamp]
|
👍 |
ttim
approved these changes
Feb 16, 2017
|
|
||
| import com.twitter.algebird.{ Intersection, Interval } | ||
| import com.twitter.scalding.{ DateParser, RichDate } | ||
| import java.util.{TimeZone, UUID} |
There was a problem hiding this comment.
nit: I think it should be with spaces (I think it's where your IDEA style settings going against our scalafmt setup).
There was a problem hiding this comment.
yeah seems like the Twitter defaults are set to not include the space :-).
johnynek
approved these changes
Feb 16, 2017
ttim
pushed a commit
to ttim/summingbird
that referenced
this pull request
May 10, 2017
ttim
pushed a commit
to ttim/summingbird
that referenced
this pull request
May 11, 2017
Closed
ttim
pushed a commit
to ttim/summingbird
that referenced
this pull request
May 26, 2017
ttim
pushed a commit
to ttim/summingbird
that referenced
this pull request
May 31, 2017
ttim
pushed a commit
to ttim/summingbird
that referenced
this pull request
Jun 2, 2017
Merged
ttim
added a commit
that referenced
this pull request
Jul 25, 2017
* Remove scala 2.10 and add scala 2.12 * Bump versions of deps * Fix algebird related issues based on #715 * Fix finagle related compilation error * Fix ClientStoreLaws * Bump scalding version * Rename TimeStamp.scala to Timestamp.scala and fix serialization of timestampSuccessible * Remove usage of JavaConversions * Trying to fix travis scalacheck fail * Introduce ArbitraryWorkaround object * Bump scalding version
|
looks like develop already has this. closing. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed that the Algebird bump broke SB in a couple of places. We might need to also bump Scalding as part of this (which I can do when we have a release out).