Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Portugal Flag 1f1f5-1f1f9 #427

Closed
wants to merge 2 commits into from

Conversation

conorhennessy
Copy link

@conorhennessy conorhennessy commented Jul 27, 2020

As @HVEVB mentioned in #414 the top right of the Portugal flag 1f1f5-1f1f9 is currently a bit wonky. The top right line has a gap.

I corrected this by moving the wonky yellow bar to line up with the outer circle. This part is now symmetrical with the left-hand side and corresponding part.

Here is a before & after comparison to reflect the changes made -
1f1f5-1f1f9 comparison

Closing the gap as outlined in issue twitter#414
Re rendered the png to reflect changes to SVG - Closing the gap as outlined in issue twitter#414
@CLAassistant
Copy link

CLAassistant commented Jul 27, 2020

CLA assistant check
All committers have signed the CLA.

@conorhennessy conorhennessy changed the title Fix Portugal flag Fix Portugal Flag 1f1f5-1f1f9 Jul 27, 2020
@Mennaruuk
Copy link

Hi! Do you know when this will be merged?

@conorhennessy
Copy link
Author

conorhennessy commented Jan 30, 2021

Hi @Mennaruuk - nope, no idea when.
CLA has been signed so just to wait for a Twitter Dev (@jdecked maybe? 😉) to merge this small change :)

@Mennaruuk
Copy link

Hi @Mennaruuk - nope, no idea when.
CLA has been signed so just to wait for a Twitter Dev (@jdecked maybe? 😉) to merge this small change :)

Awesomesauce. Can't wait for the new flag! Looks crispy.

@jdecked
Copy link
Contributor

jdecked commented Jan 31, 2021

Good catch @conorhennessy! This will be in our next release, but I'm waiting on the Design team for the assets for the new emojis slated to be in that release too, so it'll still be another little while.

Edit: To be clear, what I expect will happen is that our Design team will make this revision themselves/has already done so (I did ask back when you posted this if it'd be OK if I merged it, but what they told me was that they had this planned for the next revision of the emoji assets). I'll continue to leave this open until I know for sure.

@conorhennessy
Copy link
Author

This issue has been fixed in v13.0.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants