Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make username option settable on requests #125

Merged
merged 3 commits into from
Dec 4, 2019
Merged

make username option settable on requests #125

merged 3 commits into from
Dec 4, 2019

Conversation

smaeda-ks
Copy link
Collaborator

@smaeda-ks smaeda-ks commented Nov 28, 2019 •
edited
Loading

feature-request: #10

Travis test should be passed once #119 is merged.

@smaeda-ks smaeda-ks self-assigned this Nov 28, 2019
@smaeda-ks smaeda-ks mentioned this pull request Nov 28, 2019
Closed
@claassistantio
Copy link

claassistantio commented Nov 28, 2019 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@coveralls
Copy link

coveralls commented Nov 28, 2019 •
edited
Loading

Coverage Status

Coverage increased (+0.1%) to 88.136% when pulling ec0eb5b on smaeda-ks:smaeda-ks/selectable-username-on-requests into 5b03096 on twitter:master.

@smaeda-ks smaeda-ks requested review from a team and removed request for andypiper and dlamacchia November 28, 2019 20:58
@grimreaper grimreaper removed the request for review from a team November 29, 2019 02:48
@smaeda-ks smaeda-ks added this to the Target v0.9.4 milestone Nov 29, 2019
@smaeda-ks
Copy link
Collaborator Author

Passed the tests, merging into master. Thanks @andypiper

@smaeda-ks smaeda-ks merged commit 1890ab9 into twitter:master Dec 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andypiper andypiper andypiper approved these changes

Assignees

@smaeda-ks smaeda-ks

Labels
Enhancement
Milestone
Target v0.9.4
Development

Successfully merging this pull request may close these issues.
4 participants
@smaeda-ks @claassistantio @coveralls @andypiper