Remote suggestions should appear after local/prefetch suggestions #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| expectedItemHash.coffee, | ||
| expectedItemHash.coconut | ||
| ]); | ||
| }, local)(remote); |
There was a problem hiding this comment.
Maybe it's the drugs, but I'm not following this (remote) part of the test. Otherwise the whole thing looks good.
There was a problem hiding this comment.
_prcessRemoteSuggestions returns a function that's expected to be called with the results of the remote request. You wrote the code!
There was a problem hiding this comment.
😦 clearly it's past my bedtime…
|
I'm right in thinking the remote suggestions should be appended to the suggestions list right? |
|
Yes, up to the limit. |
|
K, this patch corrects the behavior then. |
|
Ship It! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See title.