Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removal of Var.memo() in 6.7.0 breaks compatibility with Finagle 6.7.1 #73

Closed
sirmax opened this issue Oct 21, 2013 · 1 comment
Closed

Comments

@sirmax
Copy link
Contributor

sirmax commented Oct 21, 2013

While using Finagle 6.7.1 in my project I've bumped the util-core dependency to the latest 6.7.0. The result is

Exception in thread "main" java.lang.NoSuchMethodError: com.twitter.util.Var.memo()Lcom/twitter/util/Var;
    at com.twitter.finagle.Group$class.set(Group.scala:46)
    at com.twitter.finagle.Group$$anon$2.set(Group.scala:153)
    at com.twitter.finagle.Group$$anon$3.<init>(Group.scala:63)
    at com.twitter.finagle.Group$class.collect(Group.scala:60)
    at com.twitter.finagle.Group$$anon$2.collect(Group.scala:153)
    at com.twitter.finagle.Group$class.map(Group.scala:53)
    at com.twitter.finagle.Group$$anon$2.map(Group.scala:153)
    at com.twitter.finagle.client.DefaultClient$$anonfun$19.apply(DefaultClient.scala:186)
    at com.twitter.finagle.client.DefaultClient$$anonfun$19.apply(DefaultClient.scala:164)
    at scala.Function1$$anonfun$compose$1.apply(Function1.scala:49)
    at com.twitter.finagle.factory.Refinery.<init>(Refinery.scala:20)
    at com.twitter.finagle.client.DefaultClient$$anonfun$21.apply(DefaultClient.scala:199)
    at com.twitter.finagle.client.DefaultClient$$anonfun$21.apply(DefaultClient.scala:199)
    at com.twitter.finagle.builder.ClientBuilder.buildFactory(ClientBuilder.scala:815)
    …

Formally, the removed Var.memo() was in public API, so either it should have been a major release, or, preferrably, the method should have been marked as deprecated, in case if anyone has already used it.

@mosesn
Copy link
Contributor

mosesn commented Feb 7, 2014

Oops, we missed this one. I thought we removed memo before moving Var from the exp package. Good catch! Unfortunately, there isn't anything we can do at this point. I think introducing a new deprecated memo at this point will just be confusing. I'm going to close this ticket for now.

@mosesn mosesn closed this as completed Feb 7, 2014
smarter pushed a commit to smarter/twitter-util that referenced this issue Aug 12, 2018
Define OptJsonWriter & put it on AttributeKey
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants