Support HP NonStop. Closes #272 #273
Conversation
|
|
|
Oh, would you also mind following our CONTRIBUTING.md guidelines? Please update your description and commit message per: https://github.com/twitter/util/blob/develop/CONTRIBUTING.md#pull-requests |
Problem When creating an com.twitter.jmv.Hotspot object on HotSpot JVMs that do not implement JVM metrics, such as the HP NONSTOP JVM, the creation fails with a javax.naming.OperationNotSupportedException. Solution As these metrics/counters are not mandatory, creation of the com.twitter.jmv.Hotspot should just continue with a WARN message that these counters are not available. Result Support for more Hotspot JVMs, such as HP NONSTOP JVM.
pvasterd
force-pushed
the
272-support-hp-nonstop
branch
from
9ab8e3b
to
3578fc6
Compare
Done! |
|
@mosesn , would be wonderful if this PR could make the 20.4.0 release. Is there anything you still want me to do? |
Yes, I think I followed the guidelines just now. |
pvasterd
changed the title
|
Closing this PR as the contents of the pull request already part of 20.4.0. |
Problem
When creating an com.twitter.jmv.Hotspot object on HotSpot JVMs that
do not implement JVM metrics, such as the HP NONSTOP JVM, the creation
fails with a javax.naming.OperationNotSupportedException.
Solution
As these metrics/counters are not mandatory, creation of the
com.twitter.jmv.Hotspot should just continue with a WARN message
that these counters are not available.
Result
Support for more Hotspot JVMs, such as HP NONSTOP JVM.
See #272