Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ShardErrors.Unwrap() support #775

Merged
merged 1 commit into from
Jul 29, 2024
Merged

Conversation

pracucci
Copy link
Contributor

I have an use case where I need to check whether the request context was canceled / timed out. It would be helpful to me if we could make ShardErrors supporting Unwrap(), so that errors.Is() works on it.

Signed-off-by: Marco Pracucci <marco@pracucci.com>
@twmb
Copy link
Owner

twmb commented Jul 18, 2024

+1, I'm aiming to release a franz-go patch release and kadm by / during this weekend.

@twmb twmb added the kadm Anything related to kadm specifically label Jul 21, 2024
@twmb twmb merged commit d5978bd into twmb:master Jul 29, 2024
4 checks passed
@pracucci pracucci deleted the add-ShardErrors-unwrap branch August 6, 2024 12:59
@twmb
Copy link
Owner

twmb commented Oct 15, 2024

I thought I got this in the last release, my mistake on the delay here. This will be in 1.18 this evening.
Edit: I did! This is in kadm, which was released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kadm Anything related to kadm specifically
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants