Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored libunshield CMakeLists to build on windows #105

Merged
merged 21 commits into from
Nov 11, 2020

Conversation

twogood
Copy link
Owner

@twogood twogood commented Sep 29, 2020

Create pull request to see if Travis and Appveyor picks it up

@kpyrkosz kpyrkosz force-pushed the wip/updating-cmake branch 2 times, most recently from 0ac952c to 694a578 Compare October 3, 2020 16:53
@kpyrkosz
Copy link
Contributor

kpyrkosz commented Oct 10, 2020

Spent some time digging in appveyor docs and found out how to have separate linux and windows configs in two different yaml files. It is possible to set up the CI for the same repo twice, with different Custom configuration .yml file name file set to .appveyor-windows.yml in first case and .appveyor-linux.yml in second. This is particularly convenient because the build procedure in both cases is diametrally different, splitting into two per-OS configurations makes it more readable and smaller. This is how it looks in practice:
https://ci.appveyor.com/project/kpyrkosz/unshield-windows
https://ci.appveyor.com/project/kpyrkosz/unshield-linux

Notice that the build above (in this PR) is still usint the old script (and even tho it flashes green it is broken).
I've restored your original travis file so it does not contain any of my modifications, the branch is mergable.

@twogood
Copy link
Owner Author

twogood commented Oct 12, 2020

Excellent work!!!

Thanks! I'll try to sort this out ASAP but I'm in a busy period right now.

@kpyrkosz
Copy link
Contributor

kpyrkosz commented Nov 6, 2020

Any progress? :)

@twogood
Copy link
Owner Author

twogood commented Nov 6, 2020

Thank you for the kind reminder @kpyrkosz. Maybe just merge? :)

PS. I heard Travis-ci is closing down their .org and we have to migrate to their .com version...

@kpyrkosz
Copy link
Contributor

Yes, you can merge, is there any obstacle in the way?

@twogood twogood merged commit 67c22ae into twogood:master Nov 11, 2020
@twogood
Copy link
Owner Author

twogood commented Nov 11, 2020

Damn, I shouldn't have squashed it, now I get the git blame....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants