(1/5) Streamline tests #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
macfreek
commented
Mar 13, 2012
macfreek
commented
- move tests to tests directory (hopefully more tests will follow)
- spaces to tabs (closes tabs or spaces #27)
- tests uses temporary file, instead of modify bigtest.nbt inplace (closes Running tests.py changes bigtest.nbt #19)
Merged
|
@twoolie If you might find some time to look at these four pull requests, that would be much appreciated. I'm aware of the large amount of commits. If they are not acceptable for some reason, let me know. Any feedback is appreciated. |
|
Sorry, I've been pulling late shifts at work lately and very little time to myself. I'll start merging ASAP. |
|
No problem, take your time. Sorry to sound impatient. I just wanted to make sure these changes are fine, so I can work on HEAD without having to rebase later. |
This is a cherry-pick of 0ba7890 for tests to allow renaming without merge conflicts later on.
Closed
setup no longer imports tests as a module; travis now calls tests.py as a script.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.