-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade Pandas version to latest version >=0.23.1 #80
Comments
Yep, this is something we should do. @thejunglejane what kind of testing do you want to do about it? |
We're currently using very little of the pandas API: we turn a sequence of date(time)s into a series and then shift the series. See assertDateTimesFrequencyEqual if you're curious. I can review the pandas changelog and run our normal suite of tests with 0.22 and 0.23 and I think that'll be enough. |
thejunglejane
added a commit
that referenced
this issue
Jun 21, 2018
leifwalsh
pushed a commit
that referenced
this issue
Jun 21, 2018
* Upgrade pandas and update dependency version range Closes #80 * Remove pandas dependency from Pipfile
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I love marbles! I also enjoyed Jane's talk at PyData Amsterdam.
My issue is that installing marbles automatically downgrades your pandas version.
If you do:
pip install pandas
it installs version 0.23.1 at the time of writing.Then running
pip install marbles
downgrades pandas to 0.21.This causes the following code to break:
I believe the line is on marbles/marbles/mixins/setup.py line 57.
I could try and do a pull request if you wanted, but I'm not sure what all tests I would need to ensure are passing?
The text was updated successfully, but these errors were encountered: