Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: Acsploit packaging #7

Merged
merged 1 commit into from
May 4, 2021
Merged

Conversation

MW-OP
Copy link

@MW-OP MW-OP commented Mar 16, 2021

Draft for changes to create a wheel out of acsploit (see #6).
Mostly its restructuring of the files and introducing a setup.py. I filled in some dummy metadata which can be extended.

@adamj26
Copy link
Collaborator

adamj26 commented Mar 18, 2021

LGTM so far. I'll push a commit or two to master to flesh out the stubbed metadata in setup.py once we land this PR.

Is there anything else you'd like to do here in this first pass before merging?
If not, I'm good to merge once the conflict in requirements.in is resolved (I think if you rebase the branch in your repo off of master in this repo that should fix the issue)

@MW-OP
Copy link
Author

MW-OP commented Apr 30, 2021

Sorry for taking so long. I just rebased the branch and fixed the conflicts. Hope everything is fine now.

@adamj26
Copy link
Collaborator

adamj26 commented May 4, 2021

Thanks for the update! LGTM

I'll push in some updates to the metadata in setup.py and README later this week

@adamj26 adamj26 merged commit fd5602a into twosixlabs:master May 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants