Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to continuously scan by ignoring specific codes #130

Merged
merged 1 commit into from
Feb 23, 2024

Conversation

qalandarov
Copy link
Contributor

Problem statement:
When scanning the same barcode again (either right away or after scanning another product) - could be done by continuous option, but the handler would be called each time which could be undesirable (for example, presenting a sheet when a code is detected). Using oncePerCode kind of does the trick, but scanning the same code again doesn't work as the name suggests.

Solution:
Ability to recognize any barcode except the specific "ignored" list which could let us put the current barcode into the ignored list and once another code is detected we update the list (like a "dynamic oncePerCode")

@qalandarov
Copy link
Contributor Author

Another one please @nathanfallet (there's one more 🙏)

Copy link

@TheGeekMax TheGeekMax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (reviewing from a friend's account cause I'm not at home)

@nathanfallet nathanfallet merged commit 9302aa1 into twostraws:main Feb 23, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants