Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manually check AVCaptureDevice access #49

Merged
merged 3 commits into from
May 24, 2022
Merged

Conversation

rholstad
Copy link
Contributor

Simple change illustrating how the existing setup code can be modified to handle initial camera access denial.

@nathanfallet
Copy link
Collaborator

@rholstad Why did you declare a function setupCaptureDevice to call it only once in AVCaptureDevice.requestAccess? What about wrapping the original code directly inside AVCaptureDevice.requestAccess?

@rholstad
Copy link
Contributor Author

rholstad commented Jan 3, 2022

@nathanfallet No reason.

@rholstad
Copy link
Contributor Author

@nathanfallet fetched upstream changes, inlined the setupCaptureDevice function, and added a setNeedsStatusBarAppearanceUpdate call since I found that the status bar remained after the privacy alert was dismissed.

@twostraws
Copy link
Owner

Thank you!

@twostraws twostraws merged commit e4257e2 into twostraws:main May 24, 2022
Jesus added a commit to Jesus/CodeScanner that referenced this pull request Jun 27, 2022
This reverts commit e4257e2, reversing
changes made to c27a661.
twostraws added a commit that referenced this pull request Jul 4, 2022
Revert "Merge pull request #49 from rholstad/main"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants