Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds SocialIcon to Framework, SocialFooter to Components #73

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jkaunert
Copy link

Adds a SocialFooter component with a SocialIcon struct to allow for easy addition of a social footer.

usage:

Group {
    SocialFooter([
      SocialIcon(
          name: "medium",
          targetURL: "https://medium.com/alwaysmakingstuff"
          ),
      SocialIcon(
          name: "github",
          targetURL: "https://github.com/always-making-stuff"
          ),
      SocialIcon(
          name: "twitch",
          targetURL: "https://twitch.tv/alwaysmakingstuff"
          ),
      SocialIcon(
          name: "YouTube",
          targetURL: "https://youtube.com/alwaysmakingstuff"
          ),
      SocialIcon(
          name: "bluesky",
          targetURL: "https://bsky.app/profile/joshuaauhsoj.bsky.social",
          customImageURL: "/images/social/bluesky.svg"
          ),
      ])
    IgniteFooter()
}
SocialFooterExample

@twostraws
Copy link
Owner

Hello! Sorry for taking so long to get around to reviewing this. I like the idea a lot, and think it will provide a lot of benefit to suers. However, a few things stuck out for me:

  • I don't think using strings is a good idea for known services, and would prefer to see an enum for common networks such as Medium, Mastodon, etc.
  • I would have expected users to provide only the relevant part of the URL for a given service, e.g. SocialIcon(server: .github, user: "twostraws"). For places where there are multiple servers, e.g. Mastodon, that might work best as an associated value to the enum case, e.g. .mastodon(server: "mastodon.social").
  • Both the foreground style and opacity modifiers feel unnecessary, like they should be at the user's discretion rather than being forced by us.
  • I don't see why SocialFooter is needed at all. Again, users can create that themselves.

@twostraws
Copy link
Owner

I haven't heard back on this in a month. I'll leave it a few more weeks, but if I don't hear anything further I'll close this PR.

@jkaunert
Copy link
Author

Sorry, been a busy month for me too. I'll make the suggested edits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants