Fixed bug that caused every system.exit call to return a non zero error code (#3)

twyleg · web-flow · commit c5d23020aebe · 2024-11-13T22:48:53.000+01:00
diff --git a/LICENSE b/LICENSE
@@ -672,3 +672,8 @@ may consider it more useful to permit linking proprietary applications with
 the library.  If this is what you want to do, use the GNU Lesser General
 Public License instead of this License.  But first, please read
 <https://www.gnu.org/licenses/why-not-lgpl.html>.
+
+
+
+
+:
diff --git a/simple_python_app/generic_application.py b/simple_python_app/generic_application.py
@@ -598,7 +598,7 @@ def start(self, argv: List[str] | None = None) -> int:
             return 0
         except SystemExit as e:
             ret = e.code
-            if ret is int:
+            if isinstance(ret, int):
                 return ret
         except BaseException as e:
             logm.exception(e)
diff --git a/tests/test_cli.py b/tests/test_cli.py
@@ -0,0 +1,41 @@
+# Copyright (C) 2024 twyleg
+# fmt: off
+import argparse
+from pathlib import Path
+
+from simple_python_app.generic_application import GenericApplication
+
+from fixtures import print_tmp_path, valid_custom_logging_config, project_dir
+
+#
+# General naming convention for unit tests:
+#               test_INITIALSTATE_ACTION_EXPECTATION
+#
+
+
+FILE_DIR = Path(__file__).parent
+
+
+class BaseTestApplication(GenericApplication):
+    def __init__(self, **kwargs):
+        super().__init__(
+            application_name="test_application",
+            version="0.0.1",
+            logging_init_default_logging_enabled=False,  # Caution: This is necessary because otherwise log init will
+            logging_init_custom_logging_enabled=False,   # remove pytest handler and caplog won't work.
+            application_config_init_enabled=False,
+            **kwargs
+        )
+
+    def run(self, argparser: argparse.ArgumentParser) -> None:
+        pass
+
+
+class TestCli:
+    def test_NoArgument_Started_SuccessfullReturnCode(self, caplog, project_dir):
+        test_app = BaseTestApplication()
+        assert test_app.start([]) == 0
+
+    def test_PrintVersion_Started_VersionPrintedSuccessfullReturnCode(self, caplog, project_dir):
+        test_app = BaseTestApplication()
+        assert test_app.start(["--version"]) == 0
