Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for OpenZeppelin sort-pair verifcation #21

Merged
merged 5 commits into from
Dec 13, 2022

Conversation

txaty
Copy link
Owner

@txaty txaty commented Nov 17, 2022

Add SortSiblingPair parameter in Config for OpenZeppelin support:

  • If it is set to true, then the sibling hash pairs are first sorted in ascending order, and then concatenated.
  • Otherwise, no change.

This PR is originated from #20 by user dev-ubq.

@codecov
Copy link

codecov bot commented Nov 17, 2022

Codecov Report

Merging #21 (413e634) into main (6ccb37a) will increase coverage by 0.39%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #21      +/-   ##
==========================================
+ Coverage   92.12%   92.51%   +0.39%     
==========================================
  Files           2        2              
  Lines         457      481      +24     
==========================================
+ Hits          421      445      +24     
  Misses         24       24              
  Partials       12       12              
Impacted Files Coverage Δ
merkle_tree.go 92.38% <100.00%> (+0.40%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Signed-off-by: txaty <xtianae@connect.ust.hk>
Signed-off-by: txaty <xtianae@connect.ust.hk>
Signed-off-by: txaty <xtianae@connect.ust.hk>
@txaty txaty merged commit 2927e5b into main Dec 13, 2022
@txaty txaty deleted the feat/open_zeppelin_sort_pair branch November 24, 2023 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants