Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display generated config #688

Conversation

caike
Copy link
Contributor

@caike caike commented Sep 5, 2023

How do you feel about displaying the generated config instead of forcing a download ? I sense that copying/pasting content like this could be more practical than downloading a file.

Configuration_–_Oura

Next step could be adding a "copy to clipboard button"

@paulobressan
Copy link
Member

I really like this idea

@paulobressan
Copy link
Member

What do you think about allowing the toml to be generated reactively with each modification of the stages and removing the export button?

@caike
Copy link
Contributor Author

caike commented Sep 5, 2023

What do you think about allowing the toml to be generated reactively with each modification of the stages and removing the export button?

Makes a lot of sense 👍 I'll give it a try

* Copy to clipboard.
* Refactor to use reducer.
@caike
Copy link
Contributor Author

caike commented Sep 5, 2023

Added realtime updates and copy to clipboard.

oura-config

@paulobressan
Copy link
Member

paulobressan commented Sep 5, 2023

Great job, tks ❤️

@scarmuega scarmuega deleted the branch txpipe:feat/implement-configuration-page September 8, 2023 00:19
@scarmuega scarmuega closed this Sep 8, 2023
@scarmuega
Copy link
Member

sorry, I didn't realized this was pointing to the other PR

@scarmuega
Copy link
Member

@caike would you be so kind of re-opening the PR branching directly from main?

@caike
Copy link
Contributor Author

caike commented Sep 8, 2023

@caike would you be so kind of re-opening the PR branching directly from main?

Sure, np. Here it is #696

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants