Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppport roles for authenticate #28

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

kadogo
Copy link

@kadogo kadogo commented Jul 20, 2015

It's not very beautiful but it work for me.

I add a new attribute groupSearchUser (role for users).
I assign this to groupsearch and do a groupsearch in the authenticate part.

If someone see a problem feel free to adapt it.

@xerya
Copy link

xerya commented Jul 8, 2016

Hi.

In your version, lines 129-130 cause authentication to fail on first try if user is not admin. Session is still set so on next try it succeeds. Personally I changed those lines to

      console.debug('ep_ldapauth.authenticate: user not admin');
      return cb([true]);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants