Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed bug for anonymous user accessing pad, fixed groupAttribute parameter usage and added displayNameAttribute parameter #3

Merged
merged 4 commits into from
Sep 5, 2013
Merged

Fixed bug for anonymous user accessing pad, fixed groupAttribute parameter usage and added displayNameAttribute parameter #3

merged 4 commits into from
Sep 5, 2013

Conversation

brenard
Copy link

@brenard brenard commented Sep 5, 2013

Hello,

For my usage, I made some fixed and improvement that I propose here :

  • I had a bug when anonymous user access to a pad (displayName unavailable)
  • I fixed usage of parameter groupAttribute witch is currently simply ignored ('member' attribute is hard-coded)
  • I added optional displayNameAttribute parameter to permit to choose attribute used as name ('cn' attribute is actualy hard-coded and leave as default).

Thank's for this useful plugin !

Benjamin

tykeal added a commit that referenced this pull request Sep 5, 2013
@tykeal
Merge pull request #3 from brenard/master
9d42313 
Fixed bug for anonymous user accessing pad, fixed groupAttribute parameter usage and added displayNameAttribute parameter
@tykeal tykeal merged commit 9d42313 into tykeal:master Sep 5, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brenard @tykeal