Adding NOT support #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You may want to review the change on bitset_spec.rb:1 where I changed: require './bitset' to require 'bitset' I wasn't familiar with how you were building, so I changed it to work for me. |
|
Merged in. |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This project is exactly what I've been looking for, but was missing bitwise not. I've added it in a fork, but thought this would be useful to others.
One thing could still be done is to check for respond_to? :! and define an operator alias if Ruby 1.9 is detected. This isn't important for me and I wasn't sure how do it from the C side anyway.
Regards,
Brendon.