Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Last Played game Presence displays wrong game #68

Open
FriendsOfGalaxy opened this issue Dec 16, 2019 · 2 comments
Open

Last Played game Presence displays wrong game #68

FriendsOfGalaxy opened this issue Dec 16, 2019 · 2 comments

Comments

@FriendsOfGalaxy
Copy link
Contributor

Hey,

on one of my accounts (1) I've played Bully and Max Payne 3 today. When i relogged to another account (2) with user_presence_mode = 1 set in config. it shows that the last played game of the account (1) is GTAV, which is incorrect.

image

Information from
https://socialclub.rockstargames.com/member/Nickname/games
seems to correctly show which game was last played (with the exception of different games played on the same date from what the screenshot shows)

Additionaly if possible it would be great to have a timestamp in users rich presence to see when was he last playing in addition to what was he playing.

response from https://scapi.rockstargames.com/profile/getprofile?nickname=Nickname&maxFriends=3
image

@tylerbrawl
Copy link
Owner

When I implemented this feature, I used the lastUgcTitle value to get the user's last played game. However, I now believe that this value changes only for games that have implemented the in-game Social Club API; this explains why GTA V is still listed as the last played game. Iterating through the ownedGames list does seem like the best solution, but there is one problem with both solutions that make the usefulness of this feature questionable: Neither list will be able to account for all games. Some games, such as Grand Theft Auto: San Andreas, do not have a Social Club page, and will not appear in this list. This means that if a user plays one of these games, then their last played game statistic will still be wrong.

Still, using the ownedGames list instead of the lastUgcTitle value seems like a better solution overall. However, a complete solution to this problem would likely require investigating the API used by the Rockstar Games Launcher, and that is an entirely separate problem that I am hesitant to get into.

tylerbrawl added a commit that referenced this issue Dec 18, 2019
Improved last played game checking (see #68).
tylerbrawl added a commit that referenced this issue Dec 18, 2019
Added timestamp for last played game (see #68).
@tylerbrawl
Copy link
Owner

I also just pushed a new feature to the fog_release branch that will display the time that has passed since the user has last played a specified game. (The smallest unit of time that is measured is days.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants