-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Establishes early rendering functionality. #16
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`test/playground.html` allows the user to interactively test building trees. This will ultimately allow for the visual inspection of trees.
Alpha draft of rendering trees, including: - Adding an SVG to a given div - Providing svg with viewBox and max-width - Drawing nodes and links Nodes currently contain: - an ellipse background - Text for nodeType (including superscript and subscripts) - Text for data No support provided for - collapsed trees - flextree - custome styling Noted issues: Currently there is no way of knowing the order of subscripts and superscripts. This is an issue with the underlying data model. Will file an issue. Noted issues: There is pretty rampant overflow issues. Not going to address until I've switched over to fextree.
duncgibbs
approved these changes
Jul 29, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To test this, see
tests/playground.html
, and... play.Alpha draft of rendering trees, including:
Nodes currently contain:
No support provided for
Noted issues: Currently there is no way of knowing the order of subscripts and superscripts. This is an issue with the underlying data model. Will file an issue.
Noted issues: There is pretty rampant overflow issues. Not going to address until I've switched over to d3-fextree.
Depends on #15