Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Establishes early rendering functionality. #16

Merged
merged 30 commits into from
Jul 30, 2020
Merged

Establishes early rendering functionality. #16

merged 30 commits into from
Jul 30, 2020

Conversation

tylercecil
Copy link
Owner

@tylercecil tylercecil commented Jul 27, 2020

To test this, see tests/playground.html, and... play.

Alpha draft of rendering trees, including:

  • Adding an SVG to a given div
  • Providing svg with viewBox and max-width
  • Drawing nodes and links

Nodes currently contain:

  • an ellipse background (always white)
  • Text for nodeType (including superscript and subscripts)
  • Text for data

No support provided for

  • collapsed trees
  • d3-flextree
  • custom styling

Noted issues: Currently there is no way of knowing the order of subscripts and superscripts. This is an issue with the underlying data model. Will file an issue.

Noted issues: There is pretty rampant overflow issues. Not going to address until I've switched over to d3-fextree.

Depends on #15

`test/playground.html` allows the user to interactively test building trees.
This will ultimately allow for the visual inspection of trees.
Alpha draft of rendering trees, including:
- Adding an SVG to a given div
- Providing svg with viewBox and max-width
- Drawing nodes and links

Nodes currently contain:
- an ellipse background
- Text for nodeType (including superscript and subscripts)
- Text for data

No support provided for
- collapsed trees
- flextree
- custome styling

Noted issues: Currently there is no way of knowing the order of subscripts and
superscripts. This is an issue with the underlying data model. Will file an
issue.

Noted issues: There is pretty rampant overflow issues. Not going to address
until I've switched over to fextree.
Copy link
Collaborator

@duncgibbs duncgibbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tylercecil tylercecil merged commit 56caf70 into master Jul 30, 2020
@tylercecil tylercecil deleted the render branch July 30, 2020 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants