Youtube API v3 + video_duration + more #43
+588
−140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also via data-title attribute. When title is set and duration is not requested - no xhr request for that video is needed!
to work with Youtube API v3
This was referenced Jul 8, 2015
|
@tylerpearson what about merging this PR? Or giving me the access to this repo to do that? |
|
Hey, sorry about that -- this looks awesome! Can you resolve the conflicts in the PR? Then I can merge it in. |
Also pointed out here tylerpearson#46 by @jaskaran27
Found by @rotemberger here: tylerpearson#47
The callback fuction is called after inserting the iframe
|
Any updates on this? Doesn't work with old API any longer |
fix minor typo in readme
|
@dimaip its solved on this fork: https://github.com/Daugilas/lazyYT |
…urls remove protocol relative urls
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main fix is to make it work with Youtube API v3: https://developers.google.com/youtube/v3/getting-started#before-you-start
Added some new features: display video duration, define/set video title, hide info/title bar, and few more advanced options described in readme.md