Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor executeCmd func and add unit tests / mock #81

Merged
merged 2 commits into from
Sep 18, 2022
Merged

Refactor executeCmd func and add unit tests / mock #81

merged 2 commits into from
Sep 18, 2022

Conversation

dswarbrick
Copy link
Contributor

This is a pretty aggressive cleanup of the executeCmd Unix socket read/write function to be a bit more compact and cause fewer allocations.

Also add simple mock / test for this function.

@dswarbrick dswarbrick changed the title Socket tests Refactor executeCmd func and add unit tests / mock Sep 18, 2022
@tynany
Copy link
Owner

tynany commented Sep 18, 2022

Thank you

@tynany tynany merged commit ee3b9f4 into tynany:master Sep 18, 2022
@dswarbrick dswarbrick deleted the socket_tests branch September 18, 2022 21:30
@daveset daveset mentioned this pull request Sep 19, 2022
Closed
@tynany tynany mentioned this pull request Oct 12, 2022
Closed
@tynany tynany linked an issue Oct 12, 2022 that may be closed by this pull request
cannot process output of show bgp vrf all ipv4 unicast summary json: unexpected end of JSON input #79
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cannot process output of show bgp vrf all ipv4 unicast summary json: unexpected end of JSON input
2 participants
@dswarbrick @tynany