Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merging dev to master #26

Merged
merged 11 commits into from
May 25, 2017
Merged

merging dev to master #26

merged 11 commits into from
May 25, 2017

Conversation

tynor88
Copy link
Owner

@tynor88 tynor88 commented May 25, 2017

This change is Reviewable

andreasnilsen and others added 11 commits May 25, 2017 12:45
…leInjector.Extensions.LifetimeScoping.

Replaced usages of removed two-argument IConstructorResolutionBehavior.GetConstructor method with single argument one.
Replaced usages of LifetimeScoping with ThreadScopedLifestyle.
* Added Renamed

This is used for RenamedFileSystemEvent

* Inherited from RenamedEventArgs

Added oldName argument

* Added CreateRenamedFileSystemEvent

added null parameter for compatibility to other functions

* Added WhenFileSystemRenamed

modified code for use of fileSystemWatcher.Renamed

* Rename file test

Added test for rename and modified other to check FileSystemRenamed

* Added option to remove FileSystemWatcher duplicated events

* Updated all Nuget packages
@tynor88
Copy link
Owner Author

tynor88 commented May 25, 2017

Reviewed 3 of 28 files at r1, 24 of 40 files at r2, 27 of 27 files at r3, 1 of 3 files at r4, 1 of 2 files at r5, 1 of 1 files at r6.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@tynor88 tynor88 merged commit 25dbec5 into master May 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants