-
Notifications
You must be signed in to change notification settings - Fork 12
[WIP] unsafe path methods #51
base: master
Are you sure you want to change the base?
Conversation
I think the best way to deploy it would probably be as an optional dependency. We could (a) create a standalone package for it (like In (a) we'd document how to opt into the unsafe typings; in (b) we'd document how to opt out. I prefer (b) between those two because it allows for the gradual typing approach, as we all noted in Slack. |
I wonder if DT would accept typings for a nonexistent module. Do we need to squat |
Does DT need to be involved at all? Could |
True, we could publish a package with only typings, no code, and enable it with |
I tested this out, it worked perfectly |
Let's do it. |
ember-unsafe-typings is mostly working. I copied over the tests from this PR. The "test suite" simply calls You'll have a runtime error when you import the nonexistent module from an ember app. I need to set up a vendor shim or remove the import somehow at build time. |
@dwickern do we want to come back and pick this up and publish it? I think it's still valuable. |
I threw together a proof of concept from our discussion today. Any path related APIs accept a
keyof
now, and you can opt into an unsafe version which takes astring
.I'm not sure how we would deploy something like this.