Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: drop support for classic component layout #721

Merged
merged 2 commits into from
Jul 9, 2024

Conversation

aklkv
Copy link
Contributor

@aklkv aklkv commented May 18, 2024

fixes: #720

@NullVoxPopuli NullVoxPopuli added the breaking A breaking change label May 18, 2024
@aklkv aklkv force-pushed the feat/classic-components-layout branch from 2664fd9 to 80d654c Compare May 18, 2024 03:34
@aklkv aklkv requested a review from NullVoxPopuli May 18, 2024 03:34
@@ -69,14 +69,6 @@ describe('Environments: Ember Loose', () => {
'/route.js',
]);

// Classic component
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we keep a parts of this test or drop it all together 🤔

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should drop everything related

@ef4
Copy link
Contributor

ef4 commented May 21, 2024

This is probably OK as long as we're ready to ship a major. But are there other things that we should be coordinating so that we don't do two majors in quick succession, given ember 6.0 is close?

@NullVoxPopuli
Copy link
Contributor

yeah, I mostly want to see where @machty is at with volar stuff, because if we're going to introduce some churn, I'd prefer we do it once with the volar stuff, and then put the v1.4 in bugfix-only mode its own branch (which I guess could happen now if folks have non-breaking bugfixes to PR)

@ef4
Copy link
Contributor

ef4 commented Jun 18, 2024

If this was green we would consider merging it.

@machty
Copy link
Contributor

machty commented Jun 18, 2024

So long as this only removes support for templates/components and NOT co-located templates, seems good to me.

FYI Volar will initially support Polaris .gts-only projects and then add support for two-file components, at which point we'll only support co-located components and not reinstate templates/components.

@machty machty merged commit 9efe7b1 into typed-ember:main Jul 9, 2024
2 of 6 checks passed
@machty
Copy link
Contributor

machty commented Jul 9, 2024

Merging this so i can work atop it as i reinstate loose mode in Volar.

@aklkv aklkv deleted the feat/classic-components-layout branch July 9, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking A breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

If route is named components model types are not inferred
4 participants