-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: drop support for classic component layout #721
Conversation
2664fd9
to
80d654c
Compare
@@ -69,14 +69,6 @@ describe('Environments: Ember Loose', () => { | |||
'/route.js', | |||
]); | |||
|
|||
// Classic component |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we keep a parts of this test or drop it all together 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should drop everything related
This is probably OK as long as we're ready to ship a major. But are there other things that we should be coordinating so that we don't do two majors in quick succession, given ember 6.0 is close? |
yeah, I mostly want to see where @machty is at with volar stuff, because if we're going to introduce some churn, I'd prefer we do it once with the volar stuff, and then put the v1.4 in bugfix-only mode its own branch (which I guess could happen now if folks have non-breaking bugfixes to PR) |
If this was green we would consider merging it. |
So long as this only removes support for FYI Volar will initially support Polaris .gts-only projects and then add support for two-file components, at which point we'll only support co-located components and not reinstate |
Merging this so i can work atop it as i reinstate loose mode in Volar. |
fixes: #720