Relax rule validation to allow unanswerable but coherent rules #6801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR Review ChecklistDo not edit the content of this comment. The PR reviewer should simply update this comment by ticking each review item below, as they get completed. Trivial Change
Code
Architecture
|
krishnangovindraj
approved these changes
May 3, 2023
flyingsilverfin
added a commit
that referenced
this pull request
Jun 1, 2023
…pes (#6815) ## What is the goal of this PR? A follow on from #6801 , we finish the rule validation relaxation implemented there. We further relax the 'then' of the rule to operate over concrete variables, as long as all the type variables that define _which_ instances to create during materialisation are concrete. For example: ``` define abstract-person sub entity, abstract, plays friendship:friend; #abstract friendship sub relation, relates friend; #non-abstract rule concrete-relation-over-abstract-players: when { $x isa abstract-person; } then { (friend: $x) isa friendship; }; ``` Is now a legal rule to write since the 'friendship' that would be created is an instance of a concrete type. ## What are the changes implemented in this PR? * Relax rule 'then' validation to only validate that the type provided in 'isa' constraints may not contain abstract types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the goal of this PR?
We allow rules to be written in a way that is semantically sensible in the schema, but may not produce any answers (specifically, if
whentypes can't have any instances because they are abstract).We therefore match the current behaviour of
matchqueries:match $r isa relation;does not throw any exceptions even if there are no concrete subtypes ofrelation. As a result, after this change, it will be possible to write rules that will never trigger any inferences, since never match any concrete types.This change allows writing and sharing 'general' rules that work over an abstract schema, only to be specialised at a later part of the development cycle.
Note that a rule
thenmust still be written using concrete, insertable types.What are the changes implemented in this PR?
We relax rule validation to log a server-side warning if the rule is not answerable, but it is coherent (eg. it makes sense in the schema).